Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Backport updates from Core #56578

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Nov 28, 2023

What?

Backports from Core to keep the HTML API in sync.

  • Fix typo in Tag Processor example comment.
  • Rewrite @todo comments.
  • Add support for new tags in HTML Processor:
    • ADDRESS, ARTICLE, ASIDE, CENTER, DETAILS, DIALOG,
    • DIR, DL, FIELDSET, FOOTER, HEADER, HGROUP, MAIN,
    • MENU, NAV, SEARCH, SECTION, SUMMARY

cc: @SergeyBiryukov this is what needs to be created whenever we make changes in Core so that we don't leave Gutenberg out of sync.

@dmsnell dmsnell added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Nov 28, 2023
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/html-api/class-gutenberg-html-tag-processor-6-4.php
❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor.php

@gziolo gziolo added the [Feature] HTML API An API for updating HTML attributes in markup label Nov 28, 2023
@dmsnell dmsnell marked this pull request as ready for review November 28, 2023 17:37
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch from cf11ccb to 5ccf502 Compare November 28, 2023 17:38
 - Fix typo in Tag Processor example comment.
 - Rewrite @todo comments.
 - Add support for new tags in HTML Processor:
    - ADDRESS, ARTICLE, ASIDE, CENTER, DETAILS, DIALOG,
    - DIR, DL, FIELDSET, FOOTER, HEADER, HGROUP, MAIN,
    - MENU, NAV, SEARCH, SECTION, SUMMARY
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch from 5ccf502 to 9d43d50 Compare November 28, 2023 18:37
@dmsnell dmsnell merged commit 9d43d50 into trunk Nov 28, 2023
51 checks passed
@dmsnell dmsnell deleted the html-api/backport-updates-from-core branch November 28, 2023 19:21
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 28, 2023
derekblank pushed a commit that referenced this pull request Dec 7, 2023
 - Fix typo in Tag Processor example comment.
 - Rewrite @todo comments.
 - Add support for new tags in HTML Processor:
    - ADDRESS, ARTICLE, ASIDE, CENTER, DETAILS, DIALOG,
    - DIR, DL, FIELDSET, FOOTER, HEADER, HGROUP, MAIN,
    - MENU, NAV, SEARCH, SECTION, SUMMARY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants